Skip to content

Fix release run lookup for annotated tags#2147

Open
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix-release-tag-run-lookup
Open

Fix release run lookup for annotated tags#2147
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix-release-tag-run-lookup

Conversation

@fallintoplace
Copy link
Copy Markdown

Fixes #2146.

lookup-run-id was resolving --tag inputs with git rev-parse <tag>, which returns the tag object SHA for annotated tags. That works for lightweight tags, but it breaks the documented release flow because cuda.core release tags are created with git tag -s, so the workflow can end up querying GitHub Actions with the wrong SHA.

This change peels tags to their underlying commit before calling gh run list, and adds a focused regression test that uses an annotated tag plus a fake gh shim to prove we pass the commit SHA through.

Checks:

  • bash -n ci/tools/lookup-run-id
  • uv run --with ruff ruff check ci/tools/tests/test_lookup_run_id.py
  • uv run --with pytest pytest --noconftest ci/tools/tests/test_lookup_run_id.py

@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot Bot commented May 27, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the CI/CD CI/CD infrastructure label May 27, 2026
@fallintoplace fallintoplace marked this pull request as ready for review May 27, 2026 22:09
Copy link
Copy Markdown
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fallintoplace, let's keep the one-liner fix.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please kindly drop this test:

  • Files in this folder are not tested anywhere in the CI, files here will bit-rot
  • This is disproportionate since lookup-run-id is already regularly used (on a per-PR basis)

@leofang leofang added this to the cuda.core v1.1.0 milestone Jun 5, 2026
@leofang leofang added bug Something isn't working P2 Low priority - Nice to have labels Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI/CD CI/CD infrastructure P2 Low priority - Nice to have

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: release run lookup fails for signed/annotated tags

2 participants